feat: refactor all regular expressions into super-expressive #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnorpelSenf
reviewed
Feb 14, 2025
| const ctx = getDummyCtx({ userInput: "/start" }); | ||
| const m = ctx.message!; | ||
|
|
||
| it("Assert new implamantation is not more than 10% slower", () => { |
There was a problem hiding this comment.
Suggested change
| it("Assert new implamantation is not more than 10% slower", () => { | |
| it("Assert new implementation is not more than 10% slower", () => { |
|
too much impact on performance, at least with the implementation I came with |
|
@roziscoding I would like to have the branch around some time, if you don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #61
besides the obvious port, some extra changes were made
--hide-stacktracestodeno task runfor debloating the test runnernotes:
commands/src/command.ts
Line 376 in 57381f5
*instead of+if the groups are already optional?todo: add perf stress test comparing to main